refactor: replace uid-safe with native implementation#1074
Open
Snafuh wants to merge 1 commit intoexpressjs:masterfrom
Open
refactor: replace uid-safe with native implementation#1074Snafuh wants to merge 1 commit intoexpressjs:masterfrom
Snafuh wants to merge 1 commit intoexpressjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uid-safe can be replace by simple native function to generate safe uids.
uid-safe uses random-bytes which in turns uses crypto.randomBytes. So this should be save in terms of NodeJs compatibility and generate the same random uids.
Edit: I gave the repo another look and this should probably target the v2 branch? I can migrate the change over if this is change is generally desirable.