fix(preview): use project scheme instead of slug for dev-build QR codes #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the
previewaction withqr-target: dev-build, the generated QR code uses the project's slug instead of the custom scheme defined inapp.config.ts.This causes issues when multiple app variants (dev, staging, production) share the same slug but have different
schemevalues — a common setup for teams testing multiple environments on the same device.Current behavior:
// app.config.ts
{ slug: "myapp", scheme: "myappdev" }
// QR code generates: exp+myapp://expo-development-client/...Expected behavior:
// app.config.ts
{ slug: "myapp", scheme: "myappdev" }
// QR code generates: myappdev://expo-development-client/...## Solution
appSlugparameter toappSchemeingetUpdateGroupQr()for claritygetVariables()continuous-deploy-fingerprintactionChanges
src/eas.tsappSlug→appSchemeparametersrc/actions/preview.tssrc/actions/continuous-deploy-fingerprint.tssrc/__tests__/eas.test.tssrc/__tests__/actions/preview.test.tsTesting
With a project using
slug: "froot"andscheme: "frootdev":exp+froot://...❌frootdev://...✅Unit tests added to verify scheme selection behavior.
New unit tests cover: