Allow overriding the command passed to Expo#287
Open
lawrencejones wants to merge 1 commit intoexpo:mainfrom
Open
Allow overriding the command passed to Expo#287lawrencejones wants to merge 1 commit intoexpo:mainfrom
lawrencejones wants to merge 1 commit intoexpo:mainfrom
Conversation
lawrencejones
force-pushed
the
lawrence-command-allow-override
branch
from
8e802bf to
0aea399
Compare
You may want to call into the command action using a provided command string rather than what comes from the GitHub Action. This is useful if you want to write an action that listens for a specific shortcut (e.g. `#release production`) which then calls the expo/eas command supported by the official action. Then you benefit from the nice shortcut, remove the possibility of misconfiguration, while keeping the official GHA's behaviour like posting builds back to the PR or responding to the original comment.
lawrencejones
force-pushed
the
lawrence-command-allow-override
branch
from
0aea399 to
2866f4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You may want to call into the command action using a provided command string rather than what comes from the GitHub Action.
This is useful if you want to write an action that listens for a specific shortcut (e.g.
#release production) which then calls the expo/eas command supported by the official action. Then you benefit from the nice shortcut, remove the possibility of misconfiguration, while keeping the official GHA's behaviour like posting builds back to the PR or responding to the original comment.Linked issue
Provide the issue(s) which this pull request relates to or fixes.
Additional context
Are there things the maintainers should be aware of before merging or closing this pull request?