Skip to content

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Jun 25, 2025

Why

Total duration goes from about 2:30 to about 1:30.

Yes, yes, I know: it's not very much. But it didn't take much either.

Test Plan

Compare these test runs:

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.39%. Comparing base (448d75b) to head (c67510f).

Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           06-23-replace_run-with-docker.sh_with_testcontainer     #302    +/-   ##
=====================================================================================
  Coverage                                                97.39%   97.39%            
=====================================================================================
  Files                                                       87       87            
  Lines                                                    11894    11894            
  Branches                                                   962      528   -434     
=====================================================================================
  Hits                                                     11584    11584            
  Misses                                                     310      310            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch from fdebc98 to 2db3b89 Compare June 25, 2025 01:50
@nicknovitski nicknovitski force-pushed the 06-23-replace_run-with-docker.sh_with_testcontainer branch from 5fc9b3b to cfeca43 Compare June 25, 2025 01:50
@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch from 2db3b89 to cb82c41 Compare June 25, 2025 20:08
@nicknovitski nicknovitski force-pushed the 06-23-replace_run-with-docker.sh_with_testcontainer branch from cfeca43 to b359525 Compare June 25, 2025 20:08
@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch from cb82c41 to 3787831 Compare June 25, 2025 20:53
@nicknovitski nicknovitski force-pushed the 06-23-replace_run-with-docker.sh_with_testcontainer branch from b359525 to 1ccd723 Compare June 25, 2025 20:53
@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch from 3787831 to 951112e Compare June 25, 2025 21:02
@nicknovitski nicknovitski force-pushed the 06-23-replace_run-with-docker.sh_with_testcontainer branch 2 times, most recently from 5d1a901 to bb4cf26 Compare June 25, 2025 21:42
@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch 2 times, most recently from a48320b to 68c5caf Compare June 26, 2025 15:27
@nicknovitski nicknovitski force-pushed the 06-23-replace_run-with-docker.sh_with_testcontainer branch 2 times, most recently from 0ba2b9c to b701e32 Compare June 26, 2025 15:32
@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch from 68c5caf to 29d916f Compare June 26, 2025 15:32
@nicknovitski nicknovitski force-pushed the 06-23-replace_run-with-docker.sh_with_testcontainer branch from b701e32 to cc926dd Compare June 26, 2025 15:36
@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch from 29d916f to 5454129 Compare June 26, 2025 15:36
@nicknovitski nicknovitski force-pushed the 06-23-replace_run-with-docker.sh_with_testcontainer branch from cc926dd to 4822750 Compare June 26, 2025 15:48
@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch from 5454129 to f8c6f6b Compare June 26, 2025 15:48
@nicknovitski nicknovitski force-pushed the 06-24-parallelize_ci_jobs branch from f8c6f6b to c67510f Compare June 26, 2025 16:19
@nicknovitski nicknovitski force-pushed the 06-23-replace_run-with-docker.sh_with_testcontainer branch from 4822750 to 448d75b Compare June 26, 2025 16:19
@nicknovitski
Copy link
Member Author

I thought of a better way to do this.

@nicknovitski nicknovitski deleted the 06-24-parallelize_ci_jobs branch December 31, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants