Skip to content

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented May 15, 2025

Why

Part 2 of #2835. Missed some cases in that one.

Essentially the username field is supplied in EAS build jobs and in the build metadata. It is only used for an environment variable which is known to be undefined for robots: https://docs.expo.dev/eas/environment-variables/#:~:text=learn%20more)-,EAS_BUILD_USERNAME,-%3A%20the%20username%20of

How

This makes two changes:

  1. If project ID is not set and a command is run that needs to generate it, it must be run as a human actor (to know which account to set it to). getAccountNameForEASProject in that path now throws if eas init has not yet been run (projectId is not yet set) and a robot is running the command.
  2. This removes the overloaded function responsibility of getUsername (used by build and build metadata). Previously this function was responsible for preventing a prebuild error it seems. This PR updates it to just get the username or return undefined for robots.

Test Plan

Run neas build as a robot with a project that has a eas project ID is SDK 53 and see it no longer throws an error.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented May 15, 2025

Size Change: -331 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -331 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.16%. Comparing base (b5305a3) to head (974f789).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/android/prepareJob.ts 50.00% 1 Missing ⚠️
packages/eas-cli/src/build/ios/prepareJob.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
+ Coverage   52.15%   52.16%   +0.01%     
==========================================
  Files         598      598              
  Lines       23888    23886       -2     
  Branches     5014     5013       -1     
==========================================
  Hits        12457    12457              
+ Misses      10412    10411       -1     
+ Partials     1019     1018       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman marked this pull request as ready for review May 15, 2025 22:53
@wschurman wschurman requested review from ide and quinlanj May 15, 2025 22:53
@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

@wschurman wschurman force-pushed the @wschurman/05-15-_eas-cli_further_no_longer_require_owner_field_for_sdk_53_or_canary branch from b4ec45f to 974f789 Compare May 17, 2025 00:14
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit 17db11f into main May 17, 2025
11 checks passed
@wschurman wschurman deleted the @wschurman/05-15-_eas-cli_further_no_longer_require_owner_field_for_sdk_53_or_canary branch May 17, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants