refactor(sdk): simplify numberize early returns#8
Open
Tozarin wants to merge 1 commit into
Open
Conversation
Signed-off-by: Старцев Матвей <tozarin@yandex.ru>
Tozarin
commented
May 7, 2026
Comment on lines
+12
to
+13
|
|
||
| const result = parseInt(value); |
Collaborator
Author
There was a problem hiding this comment.
parseInt без radix - потенциальный баг (parseInt('0x10') === 16). Передай радикс явно: parseInt
Tozarin
commented
May 7, 2026
Comment on lines
+14
to
+17
|
|
||
| if (isNaN(result)) { | ||
| return undefined; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
parseInt вернёт 123 - пройдёт мимо isNaN и вернёт частично распарсенное число. Замени на Number или добавь pre-check /^-?\d+$/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.