Open
Conversation
Signed-off-by: Старцев Матвей <tozarin@yandex.ru>
Tozarin
commented
Nov 20, 2025
Comment on lines
+328
to
+336
| if (apiVersion === 'v1' && !sDB.apiKey) { | ||
| throw { | ||
| message: 'API Key is required for Airtable API v1', | ||
| }; | ||
| } | ||
| if (apiVersion === 'v2' && !sDB.personalAccessToken) { | ||
| throw { | ||
| message: 'Personal Access Token is required for Airtable API v2', | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
Тут лучше использовать switch по apiVersion
Tozarin
commented
Nov 20, 2025
Comment on lines
+105
to
+112
| if (apiVersion === 'v1' && !details.apiKey) { | ||
| NcError.badRequest('API Key is required for Airtable API v1'); | ||
| } | ||
|
|
||
| if (apiVersion === 'v2' && !details.personalAccessToken) { | ||
| NcError.badRequest( | ||
| 'Personal Access Token is required for Airtable API v2', | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Нужен switch по apiVersion
Tozarin
commented
Nov 20, 2025
Comment on lines
+39
to
+46
| if (apiVersion === 'v1' && !details.apiKey) { | ||
| NcError.badRequest('API Key is required for Airtable API v1'); | ||
| } | ||
|
|
||
| if (apiVersion === 'v2' && !details.personalAccessToken) { | ||
| NcError.badRequest( | ||
| 'Personal Access Token is required for Airtable API v2', | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Надо использовать switch по apiVersion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.