Open
Conversation
Tozarin
commented
Nov 1, 2025
Comment on lines
+751
to
+752
| # Configurable Newsfeed API version (default: "v1") | ||
| NEWSFEED_API_VERSION = 'v1' |
Collaborator
Author
There was a problem hiding this comment.
NEWSFEED_API_VERSION надо предварительно пытаться получить из configuration
Tozarin
commented
Nov 1, 2025
Comment on lines
+755
to
+761
| if NEWSFEED_API_VERSION == 'v1': | ||
| NEWSFEED_URL = 'https://api.netbox.oss.netboxlabs.com/v1/newsfeed/' | ||
| elif NEWSFEED_API_VERSION == 'v2': | ||
| NEWSFEED_URL = f'https://api.netbox.oss.netboxlabs.com/newsfeed/?version=2' | ||
| else: | ||
| # Fallback to base URL for any other version | ||
| NEWSFEED_URL = 'https://api.netbox.oss.netboxlabs.com/newsfeed/' |
Collaborator
Author
There was a problem hiding this comment.
Базовый путь https://api.netbox.oss.netboxlabs.com/ надо вынести в отдельную переменную
Tozarin
force-pushed
the
api-change-downgrade
branch
2 times, most recently
from
441a05f to
a4e6a26
Compare
Tozarin
force-pushed
the
main
branch
2 times, most recently
from
b2b46de to
0bc8660
Compare
oveeernight
force-pushed
the
api-change-downgrade
branch
from
3518e4f to
97a9632
Compare
Signed-off-by: Старцев Матвей <tozarin@yandex.ru>
oveeernight
force-pushed
the
api-change-downgrade
branch
from
97a9632 to
5d5855d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.