Skip to content

Replace six from django.utils with the external package#2

Open
KBenas wants to merge 3 commits into
exploreshaifali:devfrom
KBenas:master
Open

Replace six from django.utils with the external package#2
KBenas wants to merge 3 commits into
exploreshaifali:devfrom
KBenas:master

Conversation

@KBenas

@KBenas KBenas commented Feb 10, 2020

Copy link
Copy Markdown

Django has removed six from django.utils package in order to drop support for Python 2:
https://docs.djangoproject.com/en/3.0/releases/3.0/#removed-private-python-2-compatibility-apis

All Django projects that use django-softdelete-it cannot be upgraded to 3.0 since six library is missing. A quick way to fix the issue is to replace six with the external package.

@exploreshaifali

Copy link
Copy Markdown
Owner

Hi @KBenas ,

Thanks for PR. Changes are fixing the issue for Python3 and are also working in Python2.

Please can you also change the version to 0.2 in setup file.

Also, I have created dev branch. So please can you update the PR to get merge into dev branch.

Thanks!

@KBenas KBenas changed the base branch from master to dev October 20, 2020 05:38
@KBenas

KBenas commented Oct 20, 2020

Copy link
Copy Markdown
Author

Hello @exploreshaifali,

Sorry for late response. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants