Support filter parameters for getGithubIssues. #1477
+246
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add design document for enhancing getGithubIssues() function with filter parameters (state, milestone, assignee, labels, etc.) while maintaining backward compatibility. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for GitHub API filter parameters: state, milestone, assignee, creator, mentioned, labels, sort, direction, since, type. All new parameters default to NULL for backward compatibility. The state parameter defaults to "all" to match existing behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hidekoji
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds filter parameters to the getGithubIssues() function to enable filtering GitHub issues by state, labels, assignee, and other criteria supported by the GitHub API.
Changes:
- Added 9 new optional filter parameters (state, milestone, assignee, creator, mentioned, labels, sort, direction, since, type) to
getGithubIssues() - Updated function documentation with comprehensive parameter descriptions
- Added a planning document detailing the implementation approach and backward compatibility strategy
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/plans/2026-01-19-github-issues-filter.md | Planning document describing the problem, solution, parameters, implementation approach, and testing strategy |
| R/system.R | Updated getGithubIssues() function signature and implementation to support filter parameters with dynamic query building |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…4 in DESCRIPTION file Enhance getGithubIssues function by adding a helper function to resolve milestone titles to their corresponding numbers, allowing users to filter issues by milestone title or number. This improves usability when interacting with the GitHub API.
Updated the resolve_milestone function to implement pagination when fetching milestones from the GitHub API. This change ensures that all milestones, both open and closed, are retrieved beyond the initial limit of 100, improving the completeness of data fetched for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your fix here
Checklist
Make sure you have performed the following items before submitting this pull request.
If not, please describe the reason.