Merge pull request #19 from experius/feature/fix_codescan_errors

iriks-it · web-flow · commit 8ec6de7f9b6f · 2025-01-27T14:02:09.000+01:00
[REFACTOR][SCOSA-329] Make sure exit isnt used anymore
diff --git a/Plugin/Magento/Store/App/Request/StorePathInfoValidator.php b/Plugin/Magento/Store/App/Request/StorePathInfoValidator.php
@@ -115,7 +115,7 @@ public function afterGetValidStoreCode(
             $response = $this->responseFactory->create();
             $response->setRedirect($request->getDistroBaseUrl() . $requestUri, 301);
             $response->sendResponse();
-            exit;
+            return ''; // This should never be reached because of the function above.
         }
 
         $storeCode = "{$websiteCode}_{$pathParts[0]}";

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ public function afterGetValidStoreCode(`
`115`	`115`	`$response = $this->responseFactory->create();`
`116`	`116`	`$response->setRedirect($request->getDistroBaseUrl() . $requestUri, 301);`
`117`	`117`	`$response->sendResponse();`
`118`		`- exit;`
	`118`	`+ return ''; // This should never be reached because of the function above.`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`$storeCode = "{$websiteCode}_{$pathParts[0]}";`