Skip to content

Commit 9763ffa

Browse files
authored
Merge pull request #18 from experius/feature/fix_codescan_errors
[REFACTOR][SCOSA-329] Added PHPMD suppress warnings for unused formal…
2 parents bd0837d + d6d5bd4 commit 9763ffa

3 files changed

Lines changed: 13 additions & 3 deletions

File tree

Plugin/Magento/Store/App/Request/StorePathInfoValidator.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ public function __construct(
7777
* @param $request
7878
* @param string $pathInfo
7979
* @return string
80+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
8081
*/
8182
public function afterGetValidStoreCode(
8283
\Magento\Store\App\Request\StorePathInfoValidator $subject,

Plugin/Magento/UrlRewrite/Model/StoreSwitcher/RewriteUrl.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public function __construct(
5050
* @param $redirectUrl
5151
* @return array
5252
* @throws \Magento\Framework\Exception\LocalizedException
53+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
5354
*/
5455
public function beforeSwitch(
5556
\Magento\UrlRewrite\Model\StoreSwitcher\RewriteUrl $subject,

Plugin/Store/App/Request/PathInfoProcessor.php

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ class PathInfoProcessor
3838
* @var \Experius\MultipleWebsiteStoreCodeUrl\Helper\Settings
3939
*/
4040
private $settings;
41-
41+
4242
/**
43-
* @var Data
43+
* @var Data
4444
*/
4545
protected $data;
4646

@@ -60,8 +60,16 @@ public function __construct(
6060
$this->data = $data;
6161
}
6262

63+
/**
64+
* @param \Magento\Store\App\Request\PathInfoProcessor $subject
65+
* @param callable $proceed
66+
* @param RequestInterface $request
67+
* @param $pathInfo
68+
* @return mixed
69+
* @throws \Magento\Framework\Exception\LocalizedException
70+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
71+
*/
6372
public function aroundProcess(
64-
/** @noinspection PhpUnusedParameterInspection */
6573
\Magento\Store\App\Request\PathInfoProcessor $subject,
6674
callable $proceed,
6775
RequestInterface $request,

0 commit comments

Comments
 (0)