Open
Conversation
This CL adds the Neon equivalent of the x86-AVX example. It changes the Makefile to build the neon example. It also modifies the provided main.c file to work for either the generated neon or avx code
Member
|
We probably need to clean up the Python code and modify the readme to point to the Neon example. I think we should merge the documentation / tutorial changes at once. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 87.78% 87.78%
=======================================
Files 84 84
Lines 20721 20721
=======================================
Hits 18190 18190
Misses 2531 2531 ☔ View full report in Codecov by Sentry. |
Contributor
|
The README.md file is out of sync with the code. Let's discuss a path to getting this committed ASAP in person. I can share an optional code rewrite with some alternate comments as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds the Neon equivalent
of the x86-AVX example. It changes
the Makefile to build the neon
example. It also modifies
the provided main.c file
to work for either the
generated neon or avx code