Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 87.74% 88.45% +0.71%
==========================================
Files 84 87 +3
Lines 20658 21256 +598
==========================================
+ Hits 18126 18802 +676
+ Misses 2532 2454 -78 ☔ View full report in Codecov by Sentry. |
71490bb to
9a2fecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(this comment is outdated. needs update)
This PR:
src/exo/dataflow.pyimplements abstract interpretation based scalar propagationstmts_effsandPostEnvto extract effects from LoopIR, but I don't use them for propagating values.Check_DeleteConfigWrite. Other checks can actually be strickter, by being value-insensitive. For instance, reorderingConfig.Load = 1.0 ; Config.Load = 1.0is invalid, but deleting one of the configurations should be valid.What I hope to do after merging this PR: