test: correct assert_equal argument order in last_will tests#1841
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Thank you for the fix. It is sent in and does not invalidate current exercises. You will want to check the forums, in case work is happening (such as the test generators) so that conflicting work is not done for no good reason. I appreciate the contribution! |
Discussed in forums here:
Summary
This PR updates the
last_willexercise tests to follow the standard Minitest convention of passing arguments toassert_equalas:instead of:
Why?
While both forms produce the same pass/fail result, reversing the arguments causes failure output to be misleading.
For example, when a learner's implementation returns
677instead of the expected67, the current tests report:which inverts the intended meaning and can make debugging more difficult.
After this change, the same failure is reported as:
which aligns with standard Minitest behavior and clearly communicates what the implementation should have returned.
Changes
assert_equalassertions to useexpected, actual.Impact
This change does not affect test outcomes. It only improves the clarity of failure messages when assertions fail.