You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes search by hash is not enough, so we use search by name but it brings many results with wrong subtitles or bad sync (inexact subtitle name, bad meta, ...).
This feature is a first try to help sort the subtitles which are the most irrelevant. VLSub window now displays the movie length, and for each subtitle the time at which the last subtitle appears. This way, last subs that appear later, or ends really sooner, than the movie end are certainly the wrong ones.
This code is tested. I had to export the necessary functions from VLSub for the tests, and to put a default value for globals to ease testing. You need lunit to run them like this : lunit tests/*
I'm open to any other solution, and would be glad to improve the code before merge.
Hi, thank you for your work.
Correct me if I'm wrong but your code doesn't currently sort or discard the subtitles based on the time difference between the movie duration and the time of the last spoken line, it just display this times them right? Sorry but I haven't much time to check this in details myself.
That's right, it only displays the time of the last spoken line. I would be against discarding (better let the user chooses what he wants). However sorting could be a good help, I can look into that : The further the last spoken line is from the movie end, the lower it will be in the list. Is that what you had in mind ?
Okay so now subs are also ordered based on distance between movie duration and last spoken line. Thanks for the suggestion !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes search by hash is not enough, so we use search by name but it brings many results with wrong subtitles or bad sync (inexact subtitle name, bad meta, ...).
This feature is a first try to help sort the subtitles which are the most irrelevant. VLSub window now displays the movie length, and for each subtitle the time at which the last subtitle appears. This way, last subs that appear later, or ends really sooner, than the movie end are certainly the wrong ones.
This code is tested. I had to export the necessary functions from VLSub for the tests, and to put a default value for globals to ease testing. You need
lunitto run them like this :lunit tests/*I'm open to any other solution, and would be glad to improve the code before merge.