ci: pin php-cs-fixer runner to ubuntu-24.04#1691
Open
oreno4649 wants to merge 1 commit into
Open
Conversation
Other workflows (phpstan, unittest, check-lang) already pin ubuntu-24.04. Aligning php-cs-fixer.yml prevents the runner from drifting when GitHub bumps the ubuntu-latest alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/php-cs-fixer.ymlだけubuntu-latestを使っていたので、他 3 ワークフロー (phpstan.yml/unittest.yml/check-lang.yml) と同じubuntu-24.04に揃えました。ubuntu-latestは GitHub 側で参照先が切り替わる (現在は 22.04、将来的に 24.04 → 26.04 など) ため、ジョブ間で実行環境がずれる/突然挙動が変わるリスクがあります。固定値で揃えることで CI の再現性を担保します。Before / After
Test plan
php-cs-fixerジョブが ubuntu-24.04 上で pass することを確認