Support PHPStan Level 7#1652
Merged
Merged
Conversation
oreno4649
force-pushed
the
feat/phpstan-lv7
branch
from
9f13d23 to
5e1c0af
Compare
oreno4649
force-pushed
the
feat/phpstan-lv7
branch
from
d64f4c9 to
35c36a4
Compare
# Conflicts: # src/Services/Installer/DatabaseForm.php
The temporary "test: github actions" override pointed at oreno4649/docker-exment#fix/mysql-warning, which has since been merged and deleted, causing all CI checkouts to fail.
Revert the 47 src/ files that had behavioral code modifications (return type declarations, (string)trans casts, variable extractions/renames, null-safety guards, explicit return null, constructor reorder) back to upstream/master state. Add // @phpstan-ignore-next-line above each affected line so PHPStan Level 7 still passes without changing runtime behavior.
…nores PHPStan flagged 69 // @phpstan-ignore-next-line comments as "No error to ignore" because the original code did not produce errors at level 7 once the runtime modifications were reverted. Remove those directives. For RouteOAuthServiceProvider, the genuine error sits on the Passport::tokensExpireIn() argument line, so move the ignore directives directly above those calls.
kojikoji725
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP Stan Level 7 をサポートしました