This repository was archived by the owner on Jun 11, 2019. It is now read-only.
Ensure NameVirtualhost is correctly created#66
Open
lermit wants to merge 2 commits intoexample42:masterfrom
Open
Ensure NameVirtualhost is correctly created#66lermit wants to merge 2 commits intoexample42:masterfrom
lermit wants to merge 2 commits intoexample42:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you create a vhost like
apache::vhost { 'www.example42.com': port => 82, }On RedHat a Namevirtualhost directive is automaticly created with *:80 as value.
Here apache::listen is call instead. This allow us to have the right ip and port.
I've left the "include apache::redhat" line in order to keep compatibility but we have to delete IMO.
Regards