Skip to content

chore: address feedback from #142 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 2 commits into from
Jun 23, 2025
Merged

chore: address feedback from #142 #145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6294524
chore: address feedback from #142
julienrbrt Jun 23, 2025
cb122bf
feedback
julienrbrt Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pkg/adapter/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package adapter
import (
"context"
"fmt"
"strconv"

abci "github.com/cometbft/cometbft/abci/types"
cmtstateproto "github.com/cometbft/cometbft/proto/tendermint/state"
Expand All @@ -26,7 +27,7 @@ type Store struct {
prefixedStore ds.Batching
}

// NewABCIStore creates a new Store with the ABCI prefix.
// NewExecABCIStore creates a new Store with the ABCI prefix.
// The data is stored under rollkit database and not in the app's database.
func NewExecABCIStore(store ds.Batching) *Store {
return &Store{
Expand All @@ -36,12 +37,14 @@ func NewExecABCIStore(store ds.Batching) *Store {
}
}

// LoadState loads the state from disk
// LoadState loads the state from disk.
// When the state does not exist, it returns an empty state.
func (s *Store) LoadState(ctx context.Context) (*cmtstate.State, error) {
data, err := s.prefixedStore.Get(ctx, ds.NewKey(stateKey))
if err != nil {
return nil, fmt.Errorf("failed to get state metadata: %w", err)
}

if data == nil {
return &cmtstate.State{}, nil
}
Expand Down Expand Up @@ -78,14 +81,15 @@ func (s *Store) SaveBlockResponse(ctx context.Context, height uint64, resp *abci
return fmt.Errorf("failed to marshal block response: %w", err)
}

key := fmt.Sprintf("%s/%d", blockResponseKey, height)
return s.prefixedStore.Put(ctx, ds.NewKey(key), data)
key := ds.NewKey(blockResponseKey).ChildString(strconv.FormatUint(height, 10))
return s.prefixedStore.Put(ctx, key, data)
}

// GetBlockResponse loads the block response from disk for a specific height
// If the block response does not exist, it returns an error.
func (s *Store) GetBlockResponse(ctx context.Context, height uint64) (*abci.ResponseFinalizeBlock, error) {
key := fmt.Sprintf("%s/%d", blockResponseKey, height)
data, err := s.prefixedStore.Get(ctx, ds.NewKey(key))
key := ds.NewKey(blockResponseKey).ChildString(strconv.FormatUint(height, 10))
data, err := s.prefixedStore.Get(ctx, key)
if err != nil {
return nil, fmt.Errorf("failed to get block response: %w", err)
}
Expand Down
Loading