[fix mistakes] add baseurl & default_etcd options#38
Open
hxsf wants to merge 2 commits intoevildecay:masterfrom
Open
[fix mistakes] add baseurl & default_etcd options#38hxsf wants to merge 2 commits intoevildecay:masterfrom
hxsf wants to merge 2 commits intoevildecay:masterfrom
Conversation
|
@hxsf please fix the conflict PR is awesome 💯 |
daydaygo
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arg: baseurl
make this app can deploy into a subpath, such as
example.com/tools/etcdkeeperarg: default_etcd
if the app is used to connect etcd in other host, auto connect to 127.0.0.1:2379 will be timeout.
feature: add
/vars.jsapi to send config to frontend by js.so it will not use ajax to get config.
feature: connect will be async
I make
connectasync, so it will not hangup the browser. and-default_etcd=""args will make it not auto connect any etcd server.