Conversation
Adopt bashkit release process conventions: - Add keywords/categories to workspace and crate metadata - Add readme paths for crates.io display - Add publish = false to fetchkit-python - Reformat CHANGELOG with Highlights section and Full Changelog link - Create [0.1.0] release section from [Unreleased] - Switch release.yml to softprops/action-gh-release with workflow_dispatch - Simplify publish.yml to match bashkit (no pre-publish test job) - Update release process docs and AGENTS.md https://claude.ai/code/session_01FESDz9faJVnHYQfZ1LEXeM
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a622731ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| prerelease: false | ||
|
|
||
| - name: Trigger publish workflow | ||
| run: gh workflow run publish.yml |
There was a problem hiding this comment.
release.yml dispatches publish with gh workflow run publish.yml but does not pass any release tag/ref context, so publish.yml runs as workflow_dispatch and github.event.release.tag_name is empty, which skips the version guard in Verify version matches tag. That means publish is no longer cryptographically tied to the release artifact and can publish whatever revision/version the dispatch resolves to (for example on reruns or branch movement), defeating the intended tag-version safety check.
Useful? React with 👍 / 👎.
2 participants
What
Prepare fetchkit v0.1.0 for first crates.io release, adopting bashkit's release process conventions.
Why
First public release. Aligning release process with bashkit for consistency across everruns projects.
How
*bullets, Full Changelog link[0.1.0]release section from[Unreleased]softprops/action-gh-release@v2withworkflow_dispatchsupportpublish = falseto fetchkit-pythonRisk
Checklist
-D warnings)cargo fmt)cargo package -p fetchkitsucceedshttps://claude.ai/code/session_01FESDz9faJVnHYQfZ1LEXeM