fix(publish): remove unpublished monty git dep for v0.1.3#180
Merged
Conversation
monty 0.0.4 not on crates.io (only 0.0.0), blocking cargo publish. Remove dep + disable python feature for registry builds. Feature remains available for git/local consumers. https://claude.ai/code/session_0197DPAFnCkDt9tYdDrdQzDK
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Add check-cfg lint config so clippy recognizes `feature = "python"` as valid even though the feature + monty dep are removed for crates.io. https://claude.ai/code/session_0197DPAFnCkDt9tYdDrdQzDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
montygit dependency frombashkitcrate (v0.0.4 not on crates.io, only 0.0.0)pythonfeature for registry builds (commented out in[features])Fixes
cargo publishfailure:failed to select a version for the requirement monty = "^0.0.4"Test plan
cargo check -p bashkitpasses (warnings only for unusedcfg(feature = "python"))cargo publish -p bashkitsucceeded in CIcargo publish -p bashkit-clisucceeded in CIhttps://claude.ai/code/session_0197DPAFnCkDt9tYdDrdQzDK