fix(ios): preserve playback speed after pause/resume and audio interruptions#146
Open
notsuhas wants to merge 1 commit intoevergrace-co:mainfrom
Open
fix(ios): preserve playback speed after pause/resume and audio interruptions#146notsuhas wants to merge 1 commit intoevergrace-co:mainfrom
notsuhas wants to merge 1 commit intoevergrace-co:mainfrom
Conversation
Author
|
@bradfloodx please do check this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVPlayer.play()implicitly setsrate = 1.0, discarding the storedcurrentPlaybackSpeedupdateNowPlayingInfocalls to usecurrentPlaybackSpeedinstead of hardcoded1.0so lock screen controls reflect the correct rateRoot Cause
AVPlayer.play()is equivalent to settingrate = 1.0. Bothresume()and the interruption-ended handler calledplayer?.play()without restoring the customrate afterward.
Android is unaffected — Media3's
play()setsplayWhenReady = truewithout changingPlaybackParameters.Test plan