Skip to content

Navigate search matches with Enter#35

Merged
everettjf merged 2 commits into
masterfrom
claude/review-and-plan-g4p9o
May 23, 2026
Merged

Navigate search matches with Enter#35
everettjf merged 2 commits into
masterfrom
claude/review-and-plan-g4p9o

Conversation

@everettjf
Copy link
Copy Markdown
Owner

Summary

Turns the layout search box into a "find next": pressing Enter jumps to the next matching node and wraps around. Matches are the nodes the filter accepts directly (by name or by the contents of an already-opened table), excluding the ancestor folders that recursive filtering keeps only for context. Selecting a match shows it in the table/hex views as usual.

Refactors the per-node match test out of filterAcceptsRow into a reusable LayoutFilterProxyModel::nodeMatches().

Verified

  • Headless: filtering Symbol finds 16 matches; repeated Enter advances through distinct matches (Section(__TEXT,__picsymbolstub4)Symbol StubsSection(__DATA,__nl_symbol_ptr) ...).
  • No crashes; full run_all.sh passes.

https://claude.ai/code/session_013kBiVXftgoEsyGVyrvfGok


Generated by Claude Code

claude added 2 commits May 23, 2026 18:58
Pressing Enter in the layout search box now jumps to the next matching node and
wraps around, so the search box is a "find next" rather than just a filter.
Matches are the nodes the filter accepts directly (by name or opened-table
content), excluding the ancestor folders that recursive filtering keeps for
context. Selecting a match shows it in the table/hex views as usual.

https://claude.ai/code/session_013kBiVXftgoEsyGVyrvfGok
@everettjf everettjf merged commit a167258 into master May 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants