feat(screenshotbase): add app and actions (take, pdf, html, advanced)#1
Open
martechdev wants to merge 1 commit intomasterfrom
Open
feat(screenshotbase): add app and actions (take, pdf, html, advanced)#1martechdev wants to merge 1 commit intomasterfrom
martechdev wants to merge 1 commit intomasterfrom
Conversation
Author
|
All feedback addressed. Requesting review.\n\nKey updates since last review:\n- Wired optional props in Take Screenshot: wait_for_selector, omit_background\n- App test request now respects base_url with fallback to https://api.screenshotbase.com and avoids double slashes\n- Added descriptions, defaults, camelCase-to-snake_case mapping, and $.summary\n- Lint is clean per guidelines\n\nThanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
WHY
Enable users to generate screenshots and PDFs directly in Pipedream workflows without custom HTTP steps. This reduces setup friction, standardizes auth, and covers common use cases (marketing previews, reports, QA snapshots, uptime/visual monitoring, social images).
HOW
TESTING
CHECKLIST