[PATCH] EB-124910 Adding pointer to extra key error dictionary field#79
Open
lautaro-eb wants to merge 2 commits intomasterfrom
Open
[PATCH] EB-124910 Adding pointer to extra key error dictionary field#79lautaro-eb wants to merge 2 commits intomasterfrom
lautaro-eb wants to merge 2 commits intomasterfrom
Conversation
eb-octavio
reviewed
Oct 10, 2019
mauro-eb
approved these changes
Oct 10, 2019
nickwilliams-eventbrite
suggested changes
Oct 10, 2019
Contributor
nickwilliams-eventbrite
left a comment
There was a problem hiding this comment.
Putting a temporary hold on this while we discuss on Slack.
vartec
suggested changes
Oct 10, 2019
Contributor
vartec
left a comment
There was a problem hiding this comment.
This is backwards incompatible change, and as such should be considered [MAJOR]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding pointer to extra key error dictionary field.
This will prevent not clear messages, for instance at the API level.
Needed Request Schema
Realized request
Response
Expected response