Skip to content

Bump MSRV to 1.94#190

Merged
samueltardieu merged 1 commit intomainfrom
push-ltxznkvlypnm
Mar 10, 2026
Merged

Bump MSRV to 1.94#190
samueltardieu merged 1 commit intomainfrom
push-ltxznkvlypnm

Conversation

@samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Mar 10, 2026

Summary by CodeRabbit

  • Chores

    • Updated minimum supported Rust version to 1.94.0.
  • Refactor

    • Improved code clarity in consistency validation logic.

@samueltardieu samueltardieu enabled auto-merge March 10, 2026 18:00
@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

📝 Walkthrough

Walkthrough

Updates the Rust version requirement from 1.85.0 to 1.94.0 and refactors a condition check in the pinned consistency validation logic to use chained conditional expressions instead of nested if statements. Behavior remains unchanged.

Changes

Cohort / File(s) Summary
Version Requirement Update
Cargo.toml
Bumps minimum Rust version from 1.85.0 to 1.94.0 in package metadata.
Condition Refactoring
src/checks.rs
Simplifies nested if conditions into a single chained if-let expression for the check_pinned_consistency logic, maintaining equivalent control flow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 Hopping through the code with glee,
Rust grows newer—1.94, you see!
Nested ifs collapse with care,
Chained conditions, sleek and fair,
The warren's updated, swift and spry!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Bump MSRV to 1.94' directly and clearly describes the main change in the pull request - updating the Rust minimum supported version from 1.85.0 to 1.94.0 in Cargo.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch push-ltxznkvlypnm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@samueltardieu samueltardieu added this pull request to the merge queue Mar 10, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Cargo.toml`:
- Line 8: The MSRV in Cargo.toml is set to "1.94.0" but the refactor only
requires Rust 1.88.0 (for Edition 2024 and stabilized let_chains); lower the
rust-version key in Cargo.toml to "1.88.0" so users on 1.88–1.93 remain
compatible, unless some other symbol in the branch (e.g., other crates or
functions referenced from src/checks.rs) explicitly requires >1.88.0—if so,
document that requirement and keep the higher MSRV only where necessary.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 938363ee-a129-4c41-9876-ca4737ee0c41

📥 Commits

Reviewing files that changed from the base of the PR and between 980291a and a5cbb02.

📒 Files selected for processing (2)
  • Cargo.toml
  • src/checks.rs

edition = "2024"
license = "Apache-2.0/MIT"
rust-version = "1.85.0"
rust-version = "1.94.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Which Rust release stabilized let_chains for Edition 2024, and in which Rust release did Rust 2024 itself become stable?

💡 Result:

  • let_chains (the #![feature(let_chains)] gate) was stabilized for the Rust 2024 Edition in Rust 1.88.0 (2025-06-26). [1]
  • Rust 2024 (Edition 2024) itself became stable in Rust 1.85.0 (2025-02-20). [2][1]

Sources
[1] Rust Release Notes (Rust 1.88.0 + Rust 1.85.0 entries) (doc.rust-lang.org)
[2] “Announcing Rust 1.85.0 and Rust 2024” (Rust Blog) (blog.rust-lang.org)

Citations:


Avoid raising the MSRV higher than this refactor needs.

Rust 2024 Edition became stable in Rust 1.85.0 (2025-02-20), and let_chains was stabilized for Edition 2024 in Rust 1.88.0 (2025-06-26). The guard refactor in src/checks.rs using chained let conditions requires only 1.88.0, not 1.94.0. Unless there is a separate requirement elsewhere in this branch that specifically needs 1.94.0, lower the MSRV to 1.88.0; otherwise, users on 1.88–1.93 unnecessarily lose compatibility.

Suggested change
-rust-version = "1.94.0"
+rust-version = "1.88.0"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
rust-version = "1.94.0"
rust-version = "1.88.0"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Cargo.toml` at line 8, The MSRV in Cargo.toml is set to "1.94.0" but the
refactor only requires Rust 1.88.0 (for Edition 2024 and stabilized let_chains);
lower the rust-version key in Cargo.toml to "1.88.0" so users on 1.88–1.93
remain compatible, unless some other symbol in the branch (e.g., other crates or
functions referenced from src/checks.rs) explicitly requires >1.88.0—if so,
document that requirement and keep the higher MSRV only where necessary.

Merged via the queue into main with commit cbe9658 Mar 10, 2026
11 checks passed
@samueltardieu samueltardieu deleted the push-ltxznkvlypnm branch March 10, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant