build: Switch Makefile from pip to uv#92
Merged
Merged
Conversation
uv-managed venvs don't include pip by default, causing `make install` to fail. Updated venv, dev, install, and reinstall targets to use uv commands instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Code ReviewSummaryThis PR switches the Makefile from pip to uv for dependency management, addressing the issue that uv-managed venvs don't include pip by default. Issues FoundCriticalNone ImportantNone Suggestions
venv:
@echo "Creating/syncing virtual environment..."
uv syncVerdictREQUEST_CHANGES - One minor simplification suggestion. Automated review by Claude Code |
uv sync is idempotent - no need for directory check. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
Feedback AddressedImplemented
|
Code ReviewSummaryThis PR switches the Makefile from pip to uv for dependency management, fixing an issue where uv-managed venvs do not include pip by default. Issues FoundCriticalNone ImportantNone Suggestions
Previously Addressed (Filtered)
VerdictREQUEST_CHANGES - Documentation should be updated to reflect the pip-to-uv change. Automated review by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make installto failTest plan
make installworks with fresh venv🤖 Generated with Claude Code