Skip to content

build: Switch Makefile from pip to uv#92

Merged
evansenter merged 2 commits into
mainfrom
fix/makefile-uv
Jan 25, 2026
Merged

build: Switch Makefile from pip to uv#92
evansenter merged 2 commits into
mainfrom
fix/makefile-uv

Conversation

@evansenter

Copy link
Copy Markdown
Owner

Summary

  • uv-managed venvs don't include pip by default, causing make install to fail
  • Updated venv, dev, install, and reinstall targets to use uv commands

Test plan

  • make install works with fresh venv

🤖 Generated with Claude Code

uv-managed venvs don't include pip by default, causing `make install` to fail.
Updated venv, dev, install, and reinstall targets to use uv commands instead.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude

claude Bot commented Jan 25, 2026

Copy link
Copy Markdown

Prompt: evansenter/dotfiles/.../claude-review.md

Code Review

Summary

This PR switches the Makefile from pip to uv for dependency management, addressing the issue that uv-managed venvs don't include pip by default.

Issues Found

Critical

None

Important

None

Suggestions

  • Makefile:23-27 - The venv target's if [ ! -d .venv ] check is now redundant since uv sync is idempotent and creates the venv if it doesn't exist. The target could be simplified to just:
venv:
	@echo "Creating/syncing virtual environment..."
	uv sync

Verdict

REQUEST_CHANGES - One minor simplification suggestion.


Automated review by Claude Code

uv sync is idempotent - no need for directory check.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@evansenter

Copy link
Copy Markdown
Owner Author

Feedback Addressed

Implemented

  • [Suggestion] Simplified venv target - removed redundant directory check since uv sync is idempotent

@claude

claude Bot commented Jan 25, 2026

Copy link
Copy Markdown

Prompt: evansenter/dotfiles/.../claude-review.md

Code Review

Summary

This PR switches the Makefile from pip to uv for dependency management, fixing an issue where uv-managed venvs do not include pip by default.

Issues Found

Critical

None

Important

None

Suggestions

  • CLAUDE.md:50 - The documentation still references pip install -e . for make reinstall, but the Makefile now uses uv sync. Consider updating to: make reinstall # uv sync + restart (for pyproject.toml changes)

Previously Addressed (Filtered)

  • Makefile:23-27 - Simplified venv target (Implemented)

1 item from prior feedback rounds was not re-raised.

Verdict

REQUEST_CHANGES - Documentation should be updated to reflect the pip-to-uv change.


Automated review by Claude Code

@evansenter evansenter merged commit e7b5b98 into main Jan 25, 2026
3 checks passed
@evansenter evansenter deleted the fix/makefile-uv branch January 25, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant