feat: Standardize MCP tool default parameters

[evansenter]

Summary

• Add limit parameter to list_sessions and classify_sessions (default: 20)
• Reduce get_session_events and get_session_messages limit: 100 → 50
• Update get_session_efficiency limit: 50 → 20
• Update find_related_sessions limit: 10 → 20
• Update guide.md documentation with new signatures

Test plan

• make check passes (381 tests)
• Verify MCP tools work with new defaults via get_status(), list_sessions()

🤖 Generated with Claude Code

[claude]

Prompt: evansenter/dotfiles/.../claude-review.md

Code Review

Summary

This PR standardizes default limit parameters across MCP tools, adding limit to list_sessions and classify_sessions, and adjusting existing defaults for consistency.

Issues Found

Critical

None

Important

• cli.py:856-860 - CLI/MCP parity violation: cmd_sessions doesn't accept or pass the new limit parameter to query_sessions(), but the MCP tool now supports limit=20. Per CLAUDE.md: "CLI/MCP parity: Every query accessible from both interfaces"
• cli.py:1108-1116 - CLI/MCP parity violation: cmd_classify doesn't accept or pass the new limit parameter to classify_sessions(), but the MCP tool now supports limit=20
• cli.py:1552-1555 - Parser missing --limit argument for sessions command
• cli.py:1671-1674 - Parser missing --limit argument for classify command

Suggestions

• cli.py:1614 - CLI journey command still defaults to limit=100, but MCP get_session_messages was changed to limit=50. Consider updating for consistency
• cli.py:1652 - CLI related command still defaults to limit=10, but MCP find_related_sessions was changed to limit=20. Consider updating for consistency
• cli.py:1821 - CLI efficiency command still defaults to limit=50, but MCP get_session_efficiency was changed to limit=20. Consider updating for consistency

Verdict

REQUEST_CHANGES - The PR adds new limit parameters to MCP tools but doesn't maintain CLI/MCP parity as required by CLAUDE.md. The sessions and classify CLI commands need corresponding --limit arguments and to pass them to the underlying query functions.

---

Automated review by Claude Code

[claude]

Prompt: evansenter/dotfiles/.../claude-review.md

Code Review

Summary

This PR standardizes default limit parameters across MCP tools and CLI commands. It adds limit to list_sessions and classify_sessions (default: 20), adjusts other defaults for consistency, and adds a "Default Parameters" reference table to CLAUDE.md explaining the rationale for semantic defaults.

Issues Found

Critical

None

Important

None

Suggestions

None

Previously Addressed (Filtered)

• cli.py:856-860 - CLI/MCP parity violation for sessions (Implemented: now passes limit=args.limit)
• cli.py:1108-1116 - CLI/MCP parity violation for classify (Implemented: now passes limit=args.limit)
• cli.py:1552-1555 - Parser missing --limit for sessions (Implemented: added)
• cli.py:1671-1674 - Parser missing --limit for classify (Implemented: added)
• cli.py:1614 - journey limit mismatch (Implemented: changed to 50)
• cli.py:1652 - related limit mismatch (Implemented: changed to 20)
• cli.py:1821 - efficiency limit mismatch (Implemented: changed to 20)

7 items from prior feedback rounds were not re-raised.

Verdict

APPROVE - All prior feedback has been addressed. MCP/CLI parity is maintained, documentation is updated, and tests include the new limit attributes.

---

Automated review by Claude Code