feat: Add expand parameter to sample_sequences() (closes #73)#83
Merged
Conversation
Adds `expand` parameter to `sample_sequences()` so users can match patterns like "git → Edit" instead of just "Bash → Edit". Uses the same expansion logic as `get_tool_sequences()`: - Bash → specific command (e.g., "git", "make") - Skill → skill name (e.g., "commit", "pr-review") - Task → subagent type (e.g., "Explore", "Plan") Changes: - Extract `_get_effective_name()` to module-level shared helper with debug logging - Add `expand` parameter to patterns.sample_sequences() and MCP tool - Add `--expand` flag to CLI sample-sequences command - Update validation to allow hyphens in expanded skill names - Add `expanded` and `status` fields to all response paths - Add `base_tool` field when tool name differs from effective name - Add 4 behavioral tests for Bash/Skill/Task expansion and hyphen validation - Update guide.md documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Code ReviewSummaryThis PR adds an Issues FoundCriticalNone ImportantNone SuggestionsNone VerdictAPPROVE - Code looks good, no issues found. The implementation correctly addresses issue #73 by:
Automated review by Claude Code |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expandparameter tosample_sequences()so users can match patterns like"git → Edit"instead of just"Bash → Edit"_get_effective_name()to shared module-level helper with debug logging for JSON parse failuresTest plan
make check)expand=Truematches Bash commandsexpand=Truematches Skill namesexpand=Truematches Task subagent_type🤖 Generated with Claude Code