fix: Normalize datetimes for timezone-aware vs naive comparison#40
Merged
Conversation
Fixes #34 - TypeError when comparing timezone-aware git commit timestamps with naive session timestamps from SQLite. - Add normalize_datetime() helper in queries.py that strips timezone info while preserving local time values - Apply normalization in correlate_git_with_sessions() for both session ranges and commit timestamps - Remove pytest.skip workarounds from test_server.py and test_cli.py - Add regression test with timezone-aware commit in test_ingest.py - Add unit tests for normalize_datetime in test_queries.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Code ReviewSummaryThis PR fixes issue #34 by adding a Issues FoundCriticalNone ImportantNone SuggestionsNone VerdictAPPROVE - Code looks good, no issues found. The implementation is well-designed:
Automated review by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_datetime()helper that strips timezone info while preserving local time valuesTest plan
normalize_datetime()in test_queries.py🤖 Generated with Claude Code