feat: Unify design patterns with event-bus

[evansenter]

Summary

Aligns design patterns between session-analytics and event-bus for consistency:

From event-bus → session-analytics:

• Add separate install-cli.sh and uninstall-cli.sh scripts for modularity
• Update install-launchagent.sh to call install-cli.sh
• Update uninstall-launchagent.sh to call uninstall-cli.sh

Documentation:

• Add cross-references to event-bus in CLAUDE.md and README.md

Related: evansenter/agent-event-bus#48

Test plan

• Verify make install calls install-cli.sh successfully
• Verify make uninstall calls uninstall-cli.sh
• Verify CLI symlink is created at ~/.local/bin/session-analytics-cli

🤖 Generated with Claude Code

[claude]

Prompt: evansenter/dotfiles/.../claude-review.md

Code Review

Summary

This PR adds modular CLI install/uninstall scripts to align with claude-event-bus patterns, integrates them into the LaunchAgent scripts, and adds cross-reference documentation between the two projects.

Issues Found

Critical

None

Important

None

Suggestions

• scripts/install-cli.sh:52 - Missing trailing newline at end of file. While functional, POSIX convention recommends files end with a newline.
• scripts/uninstall-cli.sh:12 - Missing trailing newline at end of file.
• scripts/uninstall-cli.sh - Missing set -e for consistency with other scripts. While the script is simple and handles errors gracefully, it would be more consistent with install-cli.sh and other scripts in the repo.

Verdict

REQUEST_CHANGES - Minor consistency issues with trailing newlines and error handling flags.

---

Automated review by Claude Code

[claude]

Prompt: evansenter/dotfiles/.../claude-review.md

Code Review

Summary

This PR adds modular CLI install/uninstall scripts to align with claude-event-bus patterns, integrates them into the LaunchAgent lifecycle, and adds cross-reference documentation between the two projects.

Issues Found

Critical

None

Important

None

Suggestions

None

Verdict

APPROVE - Previous feedback has been addressed. The scripts are well-structured, idempotent, and follow good shell scripting practices with proper error handling (set -e), trailing newlines, and helpful user messages.

---

Automated review by Claude Code

[claude]

Prompt: evansenter/dotfiles/.../claude-review.md

Code Review

Summary

This PR aligns design patterns between session-analytics and event-bus by adding modular CLI install/uninstall scripts, integrating them into the LaunchAgent lifecycle, and adding cross-reference documentation.

Issues Found

Critical

None

Important

None

Suggestions

None

Verdict

APPROVE - Code looks good, no issues found. The scripts are well-structured with proper error handling (set -e), idempotency (existing symlink detection), helpful user feedback (PATH warnings), and good integration with the existing LaunchAgent scripts. Previous review feedback has been addressed.

---

Automated review by Claude Code