Open
Conversation
evanmcc
reviewed
Jan 26, 2017
src/gpb_compile.erl
Outdated
| OrUndefined = case get_mapping_and_unset_by_opts(Opts) of | ||
| records -> | ||
| case gpb:is_msg_proto3(MsgName, Defs) of | ||
| true -> ""; |
Owner
There was a problem hiding this comment.
I don't think that this actually does what we want. Could you paste an example of the warning that you're trying to fix?
Author
|
It generates The It should look like this: |
Owner
|
OK, I see what you mean. I still don't think that your fix does the right thing. I'll add it to the list of stuff to fix when I finally get back to trying to get this merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this fixes the dialyzer issues, but I can't tell for sure. Referencing a fork of a fork to test it in Nucleus is a pain.