Skip to content

fix: stop scoring narration beside tool calls; hide untested effect placeholders - #69

Merged
babaliauskas merged 1 commit into
mainfrom
fix/narration-and-skipped-effect
Oct 27, 2026
Merged

babaliauskas merged 1 commit into
mainfrom
fix/narration-and-skipped-effect

Conversation

@babaliauskas

Copy link
Copy Markdown
Collaborator

Summary

Two bugs found while reading a real planner-suite run (Sonnet 4.6 → 5.5) that came back inconclusive.

1. semantic / llm_judge scored narration as an answer.
Without tool-result fixtures the replay stops at the first tool call, so any text a model writes beside that call is narration ("Let me look up your notes!"), not the answer a user would read. The source narrated beside 4 of its calls, the target did not, and both evaluators scored each as a −1.0 loss: 8 of the 20 regressions behind the verdict.

  • New ToolTrace.ends_in_tool_calls (last round has calls).
  • _score_one returns no record for semantic / llm_judge when either side ends in a tool call; coverage books the pair as not applicable. structural and the tool evaluators are unchanged.

Re-scoring the same run: equivalence 72.2% → 83.9% (52/62), regression rate 27.8% → 16.1%. On a first-round-only agent suite the two text evaluators now honestly report Nothing measured (the existing recommendation explains it), instead of fabricated drops. captures.rounds: all is the way to get them real answers to compare.

2. The evaluator table printed a skipped test's placeholders.
A uniform −1.000 drop rendered as 0.00 negligible [0.00, 0.00]. When test == "skipped", Effect and 95% range now read —, and the executive summary drops the magnitude word. Effect is now shown signed (-0.44, not 0.44), so it sits inside its own range [-0.70, -0.22]; the slice table matches.

Docs (DOCS.md, llms-full.txt, docs/evaluators.md, docs/methodology.md) and CHANGELOG.md updated.

Test plan

  • New failing-first tests: TestToolTraceRounds (ends_in_tool_calls), TestTextEvaluatorsSkipUnfinishedTurns (both/either side, both answered, structural unaffected), report tests for untested rows and signed effect.
  • ruff check, ruff format --check, mypy --strict clean; full pytest passes apart from test_online_sync_says_it_ignores_limits_it_cannot_read, which fails identically on main locally on macOS (Rich wraps the long temp path), CI-green on Linux.
  • Re-scored the real planner run with this branch: semantic/judge rows gone, report shows — / signed effects.

🤖 Generated with Claude Code

…laceholders

semantic and llm_judge compared the text a model wrote beside a tool call.
Without tool-result fixtures the replay stops at the call, so that text is
narration ("Let me check!"), not an answer. On a real planner run the source
narrated beside four calls and the target did not, and both evaluators scored
each as a -1.0 loss: 8 of the 20 regressions behind an inconclusive verdict.
A pair where either side's turn ended in a tool call now writes no record for
these two evaluators and counts as not applicable; structural checks and the
tool evaluators still score it.

The report's evaluator table printed a skipped test's placeholder d and CI as
"0.00 negligible [0.00, 0.00]" beside a uniform -1.000 drop. Effect and 95%
range now read "-" when no test ran, the executive summary drops the
magnitude word there, and Effect is shown signed so it sits inside its range.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@babaliauskas
babaliauskas merged commit 204eab6 into main Oct 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant