Repository navigation
fix: stop scoring narration beside tool calls; hide untested effect placeholders - #69
Merged
Merged
Conversation
…laceholders
semantic and llm_judge compared the text a model wrote beside a tool call.
Without tool-result fixtures the replay stops at the call, so that text is
narration ("Let me check!"), not an answer. On a real planner run the source
narrated beside four calls and the target did not, and both evaluators scored
each as a -1.0 loss: 8 of the 20 regressions behind an inconclusive verdict.
A pair where either side's turn ended in a tool call now writes no record for
these two evaluators and counts as not applicable; structural checks and the
tool evaluators still score it.
The report's evaluator table printed a skipped test's placeholder d and CI as
"0.00 negligible [0.00, 0.00]" beside a uniform -1.000 drop. Effect and 95%
range now read "-" when no test ran, the executive summary drops the
magnitude word there, and Effect is shown signed so it sits inside its range.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs found while reading a real planner-suite run (Sonnet 4.6 → 5.5) that came back
inconclusive.1.
semantic/llm_judgescored narration as an answer.Without tool-result fixtures the replay stops at the first tool call, so any text a model writes beside that call is narration ("Let me look up your notes!"), not the answer a user would read. The source narrated beside 4 of its calls, the target did not, and both evaluators scored each as a −1.0 loss: 8 of the 20 regressions behind the verdict.
ToolTrace.ends_in_tool_calls(last round has calls)._score_onereturns no record forsemantic/llm_judgewhen either side ends in a tool call; coverage books the pair as not applicable.structuraland the tool evaluators are unchanged.Re-scoring the same run: equivalence 72.2% → 83.9% (52/62), regression rate 27.8% → 16.1%. On a first-round-only agent suite the two text evaluators now honestly report Nothing measured (the existing recommendation explains it), instead of fabricated drops.
captures.rounds: allis the way to get them real answers to compare.2. The evaluator table printed a skipped test's placeholders.
A uniform −1.000 drop rendered as
0.00 negligible [0.00, 0.00]. Whentest == "skipped", Effect and 95% range now read—, and the executive summary drops the magnitude word. Effect is now shown signed (-0.44, not0.44), so it sits inside its own range[-0.70, -0.22]; the slice table matches.Docs (
DOCS.md,llms-full.txt,docs/evaluators.md,docs/methodology.md) andCHANGELOG.mdupdated.Test plan
TestToolTraceRounds(ends_in_tool_calls),TestTextEvaluatorsSkipUnfinishedTurns(both/either side, both answered, structural unaffected), report tests for untested rows and signed effect.ruff check,ruff format --check,mypy --strictclean; fullpytestpasses apart fromtest_online_sync_says_it_ignores_limits_it_cannot_read, which fails identically onmainlocally on macOS (Rich wraps the long temp path), CI-green on Linux.—/ signed effects.🤖 Generated with Claude Code