Repository navigation
fix(report): tint a target trace red only when its tool calls differ - #66
Merged
Merged
Conversation
A card flagged for its wording alone showed both sides making the same tool call with the target's in a red box, which read as a tool failure. The box and a target's "(no tool calls)" are now red only when the pair's tool diff is non-empty, and a within-threshold finding sits in a neutral notice instead of the warning tint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A follow-up to #65 from looking at a real converter report.
convert_currencycall, with the target's in a red box. That read as a tool failure when there wasn't one. "Differ" means the pair's tool diff is not empty: same rule as the card's "Tool diffs" list, so the box and the list agree. Applies to imported agent traces too (theirtrace_diff).Template and CSS only (
report.html.j2,report.css); no data orreport.jsonchange.Test plan
New tests:
notice-neutraland regressed cards don't.Each failed before the change.
make ci: ruff, ruff format,mypy --strict, and pytest (3396 passed, 95.3% coverage)pre-commit run --all-filesRe-rendered the real converter run and checked headless-Chromium screenshots: a regressed card with matching calls and an opened within-threshold card are both neutral where nothing differs
🤖 Generated with Claude Code