feat: harden EvalOpsBot requested review control plane#98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live validation
3820890163140100000handledpull_request.review_requestedwith202 OK.26135712754completed successfully from the webhook dispatch.evalops/.github#97received an EvalOpsBot PR lens comment with two P0 findings andevalops-pr-lens/meta-reviewfailed the canary head as expected. The canary PR was then closed and the branch deleted.Test Plan
ruby -Itest test/evalops_pr_lens_review_test.rbruby -Itest test/evalopsbot_webhook_relay_test.rbruby -Itest test/verify_evalopsbot_review_setup_test.rbruby -Itest test/verify_org_control_plane_contract_test.rbactionlint .github/workflows/evalops-pr-lens-review.yml .github/workflows/evalopsbot-review-request-dispatch.yml .github/workflows/evalopsbot-review-canary.yml .github/workflows/evalopsbot-review-setup-audit.yml