Skip to content

fix: backfill rollout status fields from logs when polling completes #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunnySoldier357 merged 2 commits into from
May 7, 2026
+23 −4
Merged

fix: backfill rollout status fields from logs when polling completes #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30f662f
fix: backfill rollout status fields from logs when polling completes
SunnySoldier357 May 6, 2026
3298857
fix: match backfilled log status to terminal status code
SunnySoldier357 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions eval_protocol/pytest/remote_rollout_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,28 @@ async def _process_row(row: EvaluationRow) -> EvaluationRow:
status_code,
)

status_message = status.get("message", "") or ""
status_details = status.get("details", []) or []
# /status only returns the code; backfill message/details/extras from Logs once.
status_message: str = ""
status_details: list = []
status_extras: dict = {}
completed_logs = await self._tracing_adapter.async_search_logs(
session, tags=[f"rollout_id:{row.execution_metadata.rollout_id}"]
)
# Pick the log row whose status code matches the terminal
# code from /status, so intermediate RUNNING checkpoints
# don't poison the backfill.
for log in completed_logs:
sd = log.get("status")
if isinstance(sd, dict) and sd.get("code") == status_code:
status_message = sd.get("message", "") or ""
Comment thread
SunnySoldier357 marked this conversation as resolved.
status_details = sd.get("details", []) or []
raw_extras = log.get("extras") or {}
status_extras = {
k: v
for k, v in raw_extras.items()
if k not in ("logger_name", "level", "timestamp")
}
break

exception = exception_for_status_code(status_code, status_message)
if exception is not None:
Expand All @@ -152,8 +172,7 @@ async def _process_row(row: EvaluationRow) -> EvaluationRow:
details=status_details,
)

status_extras = (status_result or {}).get("extras")
if isinstance(status_extras, dict):
if status_extras:
if row.execution_metadata.extra:
row.execution_metadata.extra.update(status_extras)
else:
Expand Down
Loading