Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches rollout execution lifecycle and shared-session cleanup behavior across parallel runs, which can affect concurrency and resource management. Retry behavior also changes for remote HTTP failures and could mask some server-side issues if misclassified.
Overview
Improves retry and resource handling for rollout execution.
rollout_processor_with_retryno longer callsrollout_processorcleanup per run; cleanup is now performed once inevaluation_test.py(including the priority-scheduler path) to avoid closing shared sessions while other parallel runs are still in flight.Expands and refines retry triggers. Default retryable exceptions now include
aiohttpconnection/disconnect errors, andRemoteRolloutProcessortreats HTTP 5xx from/initas aConnectionError(retryable) while keeping 4xx as non-retryable failures.Tests are updated to stop asserting per-run cleanup from
rollout_processor_with_retry.Written by Cursor Bugbot for commit a11c7dd. This will update automatically on new commits. Configure here.