Merged
Conversation
bigBrain1901
approved these changes
Dec 9, 2025
dphuang2
reviewed
Dec 9, 2025
|
|
||
|
|
||
| DEFAULT_MODEL_ID = "fireworks_ai/accounts/fireworks/models/glm-4p6" | ||
| DEFAULT_MODEL_ID = "fireworks_ai/accounts/pyroworks/deployedModels/minimax-m2-zmi4qk9f" |
Collaborator
There was a problem hiding this comment.
lets keep it as serverless
Collaborator
There was a problem hiding this comment.
unless this was meant to be used only for internal use and we don't mind keeping it pointed at pyroworks
Contributor
Author
There was a problem hiding this comment.
yeah it is just internal use
dphuang2
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Propose changes to the codebase
title: "Brief description of changes"
labels: ''
assignees: ''
Description
Please include a summary of the change and which issue is fixed or feature is implemented. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Implements # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Checklist:
black .,isort .,flake8 .)Screenshots (if applicable)
If applicable, add screenshots to help showcase your changes.
Additional context
Add any other context about the PR here.
Note
Switches tests to a new default model, generalizes content handling, inlines a tool schema, replaces a required-params test, removes a recovery/retry test, and updates reasoning tests to use the default model.
DEFAULT_MODEL_IDtofireworks_ai/accounts/pyroworks/deployedModels/minimax-m2-zmi4qk9f; updated all reasoning/structured-output tests to useDEFAULT_MODEL_IDinstead ofdeepseek-v3p1._coerce_content_to_strparam typing tolist[Any]and removedChatCompletionContentPartTextParamimport.test_brace_bugtool schema inPEER_TOOL_BRACE_PAYLOAD(was referencing external definition).PEER_TOOL_RECOVERY_FAILURE_PAYLOAD, its row, andtest_streaming_tool_retry_behavior._PEER_TOOL_REQUIRED_PARAMS_ROWandtest_streaming_tool_required_params_present; updated metrics (required_params_present) and reasons.Written by Cursor Bugbot for commit d0570aa. This will update automatically on new commits. Configure here.