Merged
Conversation
xiaoyifan
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Enforces a 63-character max for output model names and generates safe defaults by truncating with a hash when necessary.
eval_protocol/cli_commands/create_rft.py):--output-modellength (<=63); print error and exit if exceeded.trainingConfig.outputModelwhen not provided.eval_protocol/fireworks_rft.py):build_default_output_modelto ensure names <=63 by truncating base and appending a 6-char hash +-rft-<uuid4[:4]>.hashlibimport for hashing.Written by Cursor Bugbot for commit 7426cc5. This will update automatically on new commits. Configure here.