Skip to content

fix default output model name length#360

Merged
mayinghan merged 1 commit intomainfrom
restrict-output-model-name-length
Dec 8, 2025
Merged

fix default output model name length#360
mayinghan merged 1 commit intomainfrom
restrict-output-model-name-length

Conversation

@mayinghan
Copy link
Collaborator

@mayinghan mayinghan commented Dec 8, 2025

Note

Enforces a 63-character max for output model names and generates safe defaults by truncating with a hash when necessary.

  • RFT CLI (eval_protocol/cli_commands/create_rft.py):
    • Validate --output-model length (<=63); print error and exit if exceeded.
    • Continue to auto-generate trainingConfig.outputModel when not provided.
  • RFT Utils (eval_protocol/fireworks_rft.py):
    • Update build_default_output_model to ensure names <=63 by truncating base and appending a 6-char hash + -rft-<uuid4[:4]>.
    • Add hashlib import for hashing.

Written by Cursor Bugbot for commit 7426cc5. This will update automatically on new commits. Configure here.

@mayinghan mayinghan marked this pull request as ready for review December 8, 2025 19:42
@mayinghan mayinghan merged commit 64ae1f1 into main Dec 8, 2025
14 of 16 checks passed
@mayinghan mayinghan deleted the restrict-output-model-name-length branch December 8, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants