Skip to content

Pr 330#357

Merged
shreymodi1 merged 18 commits intomainfrom
pr-330
Dec 4, 2025
Merged

Pr 330#357
shreymodi1 merged 18 commits intomainfrom
pr-330

Conversation

@shreymodi1
Copy link
Contributor

@shreymodi1 shreymodi1 commented Dec 3, 2025


name: Pull Request
about: Propose changes to the codebase
title: "Brief description of changes"
labels: ''
assignees: ''


Description

Please include a summary of the change and which issue is fixed or feature is implemented. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Implements # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactoring/Code cleanup
  • Build/CI/CD related changes
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project (ran black ., isort ., flake8 .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots (if applicable)

If applicable, add screenshots to help showcase your changes.

Additional context

Add any other context about the PR here.


Note

Adds a new multi-app MCP test dataset and updates the pytest to use it with the kimi-k2-thinking model, switches MCP auth to KLAVIS_AUTH_TOKEN, and removes the old Gmail-only dataset.

  • Tests:
    • Update tests/pytest/test_pytest_klavis_mcp.py to use dataset klavis_mcp_test.jsonl and model accounts/fireworks/models/kimi-k2-thinking.
    • Add brief setup note for Notion test data.
  • Datasets:
    • Add tests/pytest/datasets/klavis_mcp_test.jsonl covering Gmail, Notion, and Outlook Calendar tasks with ground truths.
    • Remove tests/pytest/datasets/gmail_inbox.jsonl.
  • Config:
    • Change MCP auth in tests/pytest/mcp_configurations/klavis_strata_mcp.json from KLAVIS_API_KEY to KLAVIS_AUTH_TOKEN.

Written by Cursor Bugbot for commit ce8821f. This will update automatically on new commits. Configure here.

"klavis-strata": {
"url": "https://strata.klavis.ai/mcp/",
"authorization": "Bearer ${KLAVIS_API_KEY}"
"url": "https://gmail-mcp-server.klavis.ai/mcp/?instance_id=74ddb651-9204-480e-9fe4-4a90d9f10c69",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Hardcoded instance ID in MCP configuration

The MCP server URL contains a hardcoded instance_id (74ddb651-9204-480e-9fe4-4a90d9f10c69) which appears to be a specific test account identifier. This value is likely environment-specific and shouldn't be committed to the repository. It would be better to use an environment variable similar to how KLAVIS_AUTH_TOKEN is handled for the authorization.

Fix in Cursor Fix in Web

@shreymodi1 shreymodi1 merged commit f162be3 into main Dec 4, 2025
9 checks passed
@shreymodi1 shreymodi1 deleted the pr-330 branch December 4, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants