Skip to content

Add ep logs suggestion to logs#349

Merged
dphuang2 merged 1 commit intomainfrom
cursor/add-ep-logs-suggestion-to-logs-gpt-5.1-codex-f8ab
Nov 26, 2025
Merged

Add ep logs suggestion to logs#349
dphuang2 merged 1 commit intomainfrom
cursor/add-ep-logs-suggestion-to-logs-gpt-5.1-codex-f8ab

Conversation

@dphuang2
Copy link
Collaborator

@dphuang2 dphuang2 commented Nov 25, 2025


name: Pull Request
about: Propose changes to the codebase
title: "Add tip to run ep logs when local UI is not detected"
labels: ''
assignees: ''


Description

This change introduces a console tip that suggests running ep logs in another terminal. This tip is displayed when the evaluation protocol's auto-open browser feature attempts to open the local logs UI but cannot detect a running ep logs server. The tip is shown only once per invocation to avoid repetitive messaging.

This improves user experience by providing clear guidance when the local logs UI doesn't automatically launch, addressing a common user query (see Slack link in task).

Fixes # (issue)
Implements # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactoring/Code cleanup
  • Build/CI/CD related changes
  • Other (please describe):

How Has This Been Tested?

This change primarily affects console output.

  • Manual verification:
    1. Run an evaluation that would normally trigger the local logs UI auto-open (e.g., ep run ...).
    2. Ensure that ep logs is not running in another terminal.
    3. Observe the console output for the "Tip: Run ep logs..." message.
    4. Run the evaluation again without starting ep logs to confirm the tip is not shown a second time within the same invocation.
    5. Start ep logs in another terminal and run the evaluation again to confirm the auto-open works and the tip is not shown.

Test Configuration:

  • Firmware version: N/A
  • Hardware: N/A
  • Toolchain: N/A
  • SDK: N/A

Checklist:

  • My code follows the style guidelines of this project (ran black ., isort ., flake8 .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (manual verification performed)
  • New and existing unit tests pass locally with my changes (no new automated tests added, existing tests unaffected)
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots (if applicable)

N/A

Additional context

The change was made based on a user request to provide a hint to run ep logs when the local UI is not detected.


Slack Thread

Open in Cursor Open in Web


Note

Adds a one-time console tip to run ep logs when the local logs UI isn't detected during auto-open.

  • Pytest evaluation (eval_protocol/pytest/evaluation_test.py):
    • Add ep_logs_prompted flag to track one-time prompting per invocation.
    • When auto-open can't find a running logs server, print a tip: run ep logs; otherwise proceed to open the browser as before.

Written by Cursor Bugbot for commit 1aba18b. This will update automatically on new commits. Configure here.

Co-authored-by: dhuang <dhuang@fireworks.ai>
@cursor
Copy link

cursor bot commented Nov 25, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@dphuang2 dphuang2 marked this pull request as ready for review November 26, 2025 00:22
@dphuang2 dphuang2 requested a review from xzrderek November 26, 2025 00:23
@dphuang2 dphuang2 merged commit 19bdd2e into main Nov 26, 2025
9 checks passed
@dphuang2 dphuang2 deleted the cursor/add-ep-logs-suggestion-to-logs-gpt-5.1-codex-f8ab branch November 26, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants