Merged
Conversation
Co-authored-by: dhuang <dhuang@fireworks.ai>
|
Cursor Agent can help with this pull request. Just |
xzrderek
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Propose changes to the codebase
title: "Add tip to run
ep logswhen local UI is not detected"labels: ''
assignees: ''
Description
This change introduces a console tip that suggests running
ep logsin another terminal. This tip is displayed when the evaluation protocol's auto-open browser feature attempts to open the local logs UI but cannot detect a runningep logsserver. The tip is shown only once per invocation to avoid repetitive messaging.This improves user experience by providing clear guidance when the local logs UI doesn't automatically launch, addressing a common user query (see Slack link in task).
Fixes # (issue)
Implements # (issue)
Type of change
How Has This Been Tested?
This change primarily affects console output.
ep run ...).ep logsis not running in another terminal.ep logs..." message.ep logsto confirm the tip is not shown a second time within the same invocation.ep logsin another terminal and run the evaluation again to confirm the auto-open works and the tip is not shown.Test Configuration:
Checklist:
black .,isort .,flake8 .)Screenshots (if applicable)
N/A
Additional context
The change was made based on a user request to provide a hint to run
ep logswhen the local UI is not detected.Slack Thread
Note
Adds a one-time console tip to run
ep logswhen the local logs UI isn't detected during auto-open.eval_protocol/pytest/evaluation_test.py):ep_logs_promptedflag to track one-time prompting per invocation.ep logs; otherwise proceed to open the browser as before.Written by Cursor Bugbot for commit 1aba18b. This will update automatically on new commits. Configure here.