refactor cli and validate before create rft#348
Merged
Conversation
dphuang2
approved these changes
Nov 26, 2025
Collaborator
dphuang2
left a comment
There was a problem hiding this comment.
big PR, i'm assuming its just reorganization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Add dataset/evaluator pre-validation and Docker controls to RFT creation, extract shared CLI utils, and update local-test/upload plus tests accordingly.
--skip-validation,--ignore-docker,--docker-build-extra,--docker-run-extra.data_loadersJSONL; preferinput_dataset; fallback to detected dataset builders.EvaluationRowschema (sampled) before upload; optionally run selected test via pytest/Docker for evaluator validation.run_evaluator_test; support Docker extras; improved error messages for multiple Dockerfiles.cli_commands/utils.pywith test discovery/selection, evaluator ID normalization, account resolution, dashboard URL/link builders, dataset ID builder, entrypoint builder, and helpers.Written by Cursor Bugbot for commit 4a25e45. This will update automatically on new commits. Configure here.