Skip to content

fix remote dataset info#347

Merged
xzrderek merged 2 commits intomainfrom
derekx/fix-remote-dataset-info
Nov 25, 2025
Merged

fix remote dataset info#347
xzrderek merged 2 commits intomainfrom
derekx/fix-remote-dataset-info

Conversation

@xzrderek
Copy link
Contributor

@xzrderek xzrderek commented Nov 25, 2025

Note

Preserves and merges input_metadata.dataset_info during remote trace updates, with tests ensuring metadata survives and includes expected fields.

  • Tracing utils:
    • Update update_row_with_remote_trace in eval_protocol/pytest/tracing_utils.py to merge remote_row.input_metadata.dataset_info into existing row.input_metadata.dataset_info (initialize if None, add missing keys without overwriting existing ones).
  • Tests:
    • Enhance tests/remote_server/test_remote_fireworks.py:
      • Seed local rows with dataset_info via rows().
      • Assert preservation of dataset_info fields and presence of added fields (data_loader_type, data_loader_num_rows).
      • Additional assertions for completion_params.model, temperature, and row_id.

Written by Cursor Bugbot for commit b9a87e7. This will update automatically on new commits. Configure here.

@xzrderek xzrderek merged commit b483e00 into main Nov 25, 2025
11 of 16 checks passed
@xzrderek xzrderek deleted the derekx/fix-remote-dataset-info branch November 25, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants