Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| api_base = os.getenv("EP_LLM_API_BASE") or os.getenv("EP_LLM_BASE_URL") | ||
| if api_base and "api_base" not in request_params: | ||
| request_params["api_base"] = api_base |
There was a problem hiding this comment.
Bug: Environment variable ignored when config has falsy api_base
The check "api_base" not in request_params prevents environment variables from being used when config.completion_params contains api_base with a falsy value like "" or None. This means if someone has an empty or null api_base in their config, the environment variables EP_LLM_API_BASE or EP_LLM_BASE_URL won't override it. The condition should check not request_params.get("api_base") to allow environment variables to override falsy config values.
xzrderek
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case is - a bit more convenient to run locally vs via build + deployment + github action