Skip to content

output model name suffix #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoyifan merged 1 commit into from
Nov 10, 2025
Merged

output model name suffix #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eval_protocol/fireworks_rft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import sys
import tempfile
import time
import uuid
from pathlib import Path
from typing import Any, Callable, Dict, Iterable, Optional, Tuple

Expand Down Expand Up @@ -224,7 +225,8 @@ def build_default_dataset_id(evaluator_id: str) -> str:

def build_default_output_model(evaluator_id: str) -> str:
base = evaluator_id.lower().replace("_", "-")
return f"{base}-rft"
uuid_suffix = str(uuid.uuid4())[:4]
Copy link

@cursor cursor bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: UUID Truncation: A Collision Course

Taking only the first 4 characters from uuid.uuid4() provides only 65,536 possible values (16^4), which creates a high collision risk. The birthday paradox means collisions become likely after just a few hundred model creations, reintroducing the "output model exists" errors this change aims to prevent. Using uuid.uuid4().hex[:8] or the full hex would provide better uniqueness.

Fix in Cursor Fix in Web

return f"{base}-rft-{uuid_suffix}"


__all__ = [
Expand Down
Loading