Skip to content

proper account detection#322

Merged
benjibc merged 4 commits intomainfrom
proper_account_detection
Nov 9, 2025
Merged

proper account detection#322
benjibc merged 4 commits intomainfrom
proper_account_detection

Conversation

@benjibc
Copy link
Contributor

@benjibc benjibc commented Nov 8, 2025


name: Pull Request
about: Propose changes to the codebase
title: "Brief description of changes"
labels: ''
assignees: ''


Description

Please include a summary of the change and which issue is fixed or feature is implemented. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Implements # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactoring/Code cleanup
  • Build/CI/CD related changes
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project (ran black ., isort ., flake8 .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots (if applicable)

If applicable, add screenshots to help showcase your changes.

Additional context

Add any other context about the PR here.


Note

Centralizes Fireworks credential loading, adds verifyApiKey fallback to resolve account ID, updates pytest upload flow to use it, and improves requirements.txt error messaging.

  • Auth:
    • Add verify_api_key_and_get_account_id to resolve account_id via verifyApiKey and new get_fireworks_api_base helper.
    • Add _get_credentials_from_config_file for single-pass retrieval of api_key and account_id.
    • Enhance get_fireworks_account_id to use verify fallback when not found in env/config; preserve profile/env precedence.
  • Pytest persist flow (eval_protocol/pytest/handle_persist_flow.py):
    • Replace ad-hoc config parsing with get_fireworks_api_key/get_fireworks_account_id and verify fallback; use get_fireworks_api_base instead of hardcoded URL.
  • Evaluation (eval_protocol/evaluation.py):
    • Clarify requirements.txt error message with actionable guidance.
  • Tests (tests/test_auth.py):
    • Adjust assertions and expectations to account for verify fallback and potential multiple file existence checks.

Written by Cursor Bugbot for commit 9655243. This will update automatically on new commits. Configure here.

@benjibc benjibc force-pushed the proper_account_detection branch from 9e073d9 to 0cfeb4d Compare November 9, 2025 17:41
@benjibc benjibc merged commit 2f4e892 into main Nov 9, 2025
9 checks passed
@benjibc benjibc deleted the proper_account_detection branch November 9, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant