Conversation
9e073d9 to
0cfeb4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Propose changes to the codebase
title: "Brief description of changes"
labels: ''
assignees: ''
Description
Please include a summary of the change and which issue is fixed or feature is implemented. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Implements # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Checklist:
black .,isort .,flake8 .)Screenshots (if applicable)
If applicable, add screenshots to help showcase your changes.
Additional context
Add any other context about the PR here.
Note
Centralizes Fireworks credential loading, adds verifyApiKey fallback to resolve account ID, updates pytest upload flow to use it, and improves requirements.txt error messaging.
verify_api_key_and_get_account_idto resolveaccount_idviaverifyApiKeyand newget_fireworks_api_basehelper._get_credentials_from_config_filefor single-pass retrieval ofapi_keyandaccount_id.get_fireworks_account_idto use verify fallback when not found in env/config; preserve profile/env precedence.eval_protocol/pytest/handle_persist_flow.py):get_fireworks_api_key/get_fireworks_account_idand verify fallback; useget_fireworks_api_baseinstead of hardcoded URL.eval_protocol/evaluation.py):tests/test_auth.py):Written by Cursor Bugbot for commit 9655243. This will update automatically on new commits. Configure here.