Skip to content

fix the base model requirement#321

Merged
xzrderek merged 2 commits intomainfrom
derekx/rft-command-fix
Nov 7, 2025
Merged

fix the base model requirement#321
xzrderek merged 2 commits intomainfrom
derekx/rft-command-fix

Conversation

@xzrderek
Copy link
Copy Markdown
Contributor

@xzrderek xzrderek commented Nov 7, 2025

Note

Enforces mutually exclusive --base-model and --warm-start-from flags (trimming empty/whitespace) and conditionally builds the trainingConfig accordingly.

  • CLI (eval_protocol/cli_commands/create_rft.py):
    • Validation: Require exactly one of --base-model or --warm-start-from; error if both or neither are provided.
    • Input normalization: Trim whitespace on both flags and treat empty strings as unset.
    • Training config: Build trainingConfig dynamically, setting baseModel or warmStartFrom only when provided; remove previous unconditional baseModel requirement.

Written by Cursor Bugbot for commit 61ca3d7. This will update automatically on new commits. Configure here.

@xzrderek xzrderek merged commit e4ba202 into main Nov 7, 2025
8 checks passed
@xzrderek xzrderek deleted the derekx/rft-command-fix branch November 7, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant