Skip to content

allow override for noop#317

Merged
benjibc merged 1 commit intomainfrom
allow_override_for_noop
Nov 5, 2025
Merged

allow override for noop#317
benjibc merged 1 commit intomainfrom
allow_override_for_noop

Conversation

@benjibc
Copy link
Copy Markdown
Contributor

@benjibc benjibc commented Nov 5, 2025

Note

Introduce --ep-no-op-rollout-processor CLI flag and EP_USE_NO_OP_ROLLOUT_PROCESSOR env var to force NoOpRolloutProcessor, and update evaluation_test to honor this override; add tests.

  • Pytest plugin (eval_protocol/pytest/plugin.py):
    • Add CLI flag --ep-no-op-rollout-processor that sets EP_USE_NO_OP_ROLLOUT_PROCESSOR=1.
  • Decorator (eval_protocol/pytest/evaluation_test.py):
    • Honor EP_USE_NO_OP_ROLLOUT_PROCESSOR to use NoOpRolloutProcessor (overrides any provided processor); still defaults to NoOpRolloutProcessor when rollout_processor is None.
  • Tests (tests/pytest/test_pytest_env_overwrite.py):
    • Add tests verifying env/flag override behavior and passthrough with NoOpRolloutProcessor, including multiple-row cases.

Written by Cursor Bugbot for commit 3e1a8a4. This will update automatically on new commits. Configure here.

@benjibc benjibc merged commit 503665c into main Nov 5, 2025
9 checks passed
@benjibc benjibc deleted the allow_override_for_noop branch November 5, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants